Skip to content

[TOOL-3268] Dashboard: Fix in-app wallet settings page form submit not working #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

[TOOL-3268] Dashboard: Fix in-app wallet settings page form submit not working #6115

merged 1 commit into from
Jan 30, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 30, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR refactors the Configure component in the embedded wallets section. It simplifies the logic for displaying custom authentication endpoint fields and enhances the structure of the AuthEndpointFieldsContent function.

Detailed summary

  • Removed the useFieldArray from the main Configure function.
  • Simplified the condition for expandCustomAuthEndpointField.
  • Moved customHeaderFields logic into AuthEndpointFieldsContent.
  • Updated the rendering of custom header inputs and their management.
  • Maintained functionality for adding and removing custom headers.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 30, 2025

TOOL-3268 form submit not working on In-app wallet settings page

@vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 5:21pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 30, 2025 5:21pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 30, 2025 5:21pm
wallet-ui ⬜️ Skipped (Inspect) Jan 30, 2025 5:21pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 30, 2025 15:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 30, 2025 15:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 30, 2025 15:23 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 54c9333

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 30, 2025
@MananTank MananTank marked this pull request as ready for review January 30, 2025 15:24
@MananTank MananTank requested review from a team as code owners January 30, 2025 15:24
@MananTank Graphite App
Copy link
Member Author

MananTank commented Jan 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (541cf0b) to head (54c9333).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6115   +/-   ##
=======================================
  Coverage   56.87%   56.87%           
=======================================
  Files        1153     1153           
  Lines       63896    63896           
  Branches     5180     5180           
=======================================
  Hits        36344    36344           
  Misses      26825    26825           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 541cf0b
packages 55.07% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 700 ms (-3.94% 🔽) 1.7 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 1.6 s (+15.47% 🔺) 4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 254 ms (+303.63% 🔺) 365 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 8 ms (-69.24% 🔽) 18 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 209 ms (+13.26% 🔺) 595 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 30, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 01-30-_tool-3268_dashboard_fix_in-app_wallet_settings_page_form_submit_not_working branch from 692e467 to 54c9333 Compare January 30, 2025 17:13
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 30, 2025 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 30, 2025 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 30, 2025 17:13 Inactive
@graphite-app graphite-app bot merged commit 54c9333 into main Jan 30, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 01-30-_tool-3268_dashboard_fix_in-app_wallet_settings_page_form_submit_not_working branch January 30, 2025 17:21
@vercel vercel bot temporarily deployed to Production – docs-v2 January 30, 2025 17:21 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 30, 2025 17:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 30, 2025 17:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @joaquim-verges